adamantal commented on a change in pull request #3494:
URL: https://github.com/apache/hadoop/pull/3494#discussion_r718248005
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/server/TestJournalNode.java
##########
@@ -281,7 +300,6 @@ public void testJournal() throws Exception {
}
-
@Test(timeout=100000)
Review comment:
Could you please readd the line here?
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalMetrics.java
##########
@@ -99,6 +100,11 @@ String getName() {
return "Journal-" + journal.getJournalId();
}
+ @Metric(value={"JournalId", "Current JournalId"}, type= Type.TAG)
Review comment:
```suggestion
@Metric(value={"JournalId", "Current JournalId"}, type=Type.TAG)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
