[ 
https://issues.apache.org/jira/browse/HADOOP-17932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

yinan zhan updated HADOOP-17932:
--------------------------------
    Description: 
the params for compareFileLengthsAndChecksums in RetriableFileCopyCommand have 
no effect

current is
{code:java}
        DistCpUtils.compareFileLengthsAndChecksums(source.getLen(), sourceFS,
                sourcePath, sourceChecksum, targetFS,
                targetPath, skipCrc, source.getLen());{code}
{code:java}
public static void compareFileLengthsAndChecksums(long srcLen,
           FileSystem sourceFS, Path source, FileChecksum sourceChecksum,
           FileSystem targetFS, Path target, boolean skipCrc,
           long targetLen) throws IOException {
  if (srcLen != targetLen) {
    throw new IOException(
        DistCpConstants.LENGTH_MISMATCH_ERROR_MSG + source + " (" + srcLen
            + ") and target:" + target + " (" + targetLen + ")");
  }
{code}
so, compare source.getLen() with source.getLen()...

It should be like below in history view
{code:java}
        DistCpUtils.compareFileLengthsAndChecksums(source.getLen(), sourceFS,
                sourcePath, sourceChecksum, targetFS,
                targetPath, skipCrc, bytesRead);
{code}
 

 

  was:
the params for compareFileLengthsAndChecksums in RetriableFileCopyCommand have 
no effect

current is
{code:java}
        DistCpUtils.compareFileLengthsAndChecksums(source.getLen(), sourceFS,
                sourcePath, sourceChecksum, targetFS,
                targetPath, skipCrc, source.getLen());{code}
compare source.getLen() with source.getLen()...

It should be like below in history view
{code:java}
        DistCpUtils.compareFileLengthsAndChecksums(source.getLen(), sourceFS,
                sourcePath, sourceChecksum, targetFS,
                targetPath, skipCrc, bytesRead);
{code}
 

 


> distcp file length comparison have no effect
> --------------------------------------------
>
>                 Key: HADOOP-17932
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17932
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: tools, tools/distcp
>    Affects Versions: 3.3.1
>            Reporter: yinan zhan
>            Priority: Major
>
> the params for compareFileLengthsAndChecksums in RetriableFileCopyCommand 
> have no effect
> current is
> {code:java}
>         DistCpUtils.compareFileLengthsAndChecksums(source.getLen(), sourceFS,
>                 sourcePath, sourceChecksum, targetFS,
>                 targetPath, skipCrc, source.getLen());{code}
> {code:java}
> public static void compareFileLengthsAndChecksums(long srcLen,
>            FileSystem sourceFS, Path source, FileChecksum sourceChecksum,
>            FileSystem targetFS, Path target, boolean skipCrc,
>            long targetLen) throws IOException {
>   if (srcLen != targetLen) {
>     throw new IOException(
>         DistCpConstants.LENGTH_MISMATCH_ERROR_MSG + source + " (" + srcLen
>             + ") and target:" + target + " (" + targetLen + ")");
>   }
> {code}
> so, compare source.getLen() with source.getLen()...
> It should be like below in history view
> {code:java}
>         DistCpUtils.compareFileLengthsAndChecksums(source.getLen(), sourceFS,
>                 sourcePath, sourceChecksum, targetFS,
>                 targetPath, skipCrc, bytesRead);
> {code}
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to