[ 
https://issues.apache.org/jira/browse/HADOOP-17925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423223#comment-17423223
 ] 

Masatake Iwasaki commented on HADOOP-17925:
-------------------------------------------

If -Pdocs is enabled, hadoop-client depends on xerces. Since the dependency 
comes from the parent (hadoop-project-dist), it is not trivial to exclude it. I 
think the BUILDING.txt just should not encourage to activate -Pdocs on building 
binary artifacts.

Given HBase is avoiding build binary and docs in one pass for different reason, 
separating build of binary and docs could be safe practice.
* 
https://lists.apache.org/thread.html/0c39364a2949fab134107eaf164723e09d895b3eb2c16610b841e033%40%3Cuser.hbase.apache.org%3E
* https://github.com/apache/hbase/blob/rel/2.4.6/dev-support/make_rc.sh#L78-L84


> Some command examples in BUILDING.txt fail due to the class duplication.
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-17925
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17925
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: documentation
>    Affects Versions: 3.3.1, 3.4.0
>         Environment: AWS workspaces Amazon Linux 2
>            Reporter: Rintaro Ikeda
>            Assignee: Masatake Iwasaki
>            Priority: Minor
>
> BUILDING.txt in 
> trunk([https://github.com/apache/hadoop/blob/4d21655d04d1b488fe37e908d75f833c1aa66b01/BUILDING.txt#L350])
>  explains how to create binary distribution with documentation and shows the 
> following command line examples.
> {noformat}
> `$ mvn package -Pdist,native,docs -DskipTests -Dtar`
> `$ mvn package -Pdist,native,docs,src -DskipTests -Dtar`
> {noformat}
> But, they output errors as follows. Class duplication causes this problem.
> Results:
> {noformat}
> [INFO] -------< org.apache.hadoop:hadoop-client-check-test-invariants 
> >--------
> [INFO] Building Apache Hadoop Client Packaging Invariants for Test 
> 3.4.0-SNAPSHOT [105/112]
> [INFO] --------------------------------[ pom 
> ]---------------------------------
> ...
> [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce 
> (enforce-banned-dependencies) @ hadoop-client-check-test-invariants ---
> [INFO] Adding ignorable dependency: org.apache.hadoop:hadoop-annotations:null
> [INFO]   Adding ignore: *
> [WARNING] Rule 1: org.apache.maven.plugins.enforcer.BanDuplicateClasses 
> failed with message:
> Duplicate classes found:
>   Found in:
>     org.apache.hadoop:hadoop-client-minicluster:jar:3.4.0-SNAPSHOT:compile
>     org.apache.hadoop:hadoop-client-runtime:jar:3.4.0-SNAPSHOT:compile
>   Duplicate classes:
>     
> org/apache/hadoop/shaded/org/apache/xerces/impl/dv/dtd/NMTOKENDatatypeValidator.class
>     
> org/apache/hadoop/shaded/org/apache/xerces/dom/DOMImplementationListImpl.class
> ...
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M1:enforce 
> (enforce-banned-dependencies) on project hadoop-client-check-test-invariants: 
> Some Enforcer rules have failed. Look above for specific messages explaining 
> why the rule failed. -> [Help 1]
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to