[ 
https://issues.apache.org/jira/browse/HADOOP-17949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423245#comment-17423245
 ] 

Steve Loughran edited comment on HADOOP-17949 at 10/1/21, 11:16 AM:
--------------------------------------------------------------------

# wrong stevel@ JIRA a/c, you want the @apache.org one.
# I'd actually like the option to throw meaningful errors, even if HDFS doesn't

* Any/all network errors SHOULD be reported
* mssing source => FNFE
* dest exists & is file: FileAlreadyExistsException

There's a whole set of extra options in the rename contract tests to support 
more failures, and having turned a lot of them on the s3a code, *never noticed 
anything failing when it expected a false*

that is, all the code which looks for the return value of rename is of the form
{code}
if (!rename(src, dest)) throw new IOException("rename failed but we don't know 
why");
{code}


was (Author: [email protected]):
# wrong stevel@ JIRA a/c, you want the @apache.org one.
# I'd actually like the option to throw meaningful errors, even if HDFS doesn't

* Any/all network errors SHOULD be reported
* mssing source => FNFE
* dest exists & is file: FileAlreadyExistsException

There's a whole set of extra options in the rename contract tests to support 
more failures, and having turned a lot of them on the s3a code, *never noticed 
anything failing when it expected a false*

that is, all the code which looks for the return value of rename is of the form

if (!rename(src, dest)) throw new IOException("rename failed but we don't know 
why");

> Improve logging for abfs rename failures.
> -----------------------------------------
>
>                 Key: HADOOP-17949
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17949
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs/azure
>            Reporter: Mukund Thakur
>            Assignee: Mukund Thakur
>            Priority: Major
>
> [https://github.infra.cloudera.com/CDH/hadoop/blob/cdpd-master/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystem.java#L431]
>  should be warn. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to