iwasakims commented on a change in pull request #3374:
URL: https://github.com/apache/hadoop/pull/3374#discussion_r720295214
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java
##########
@@ -1445,12 +1451,18 @@ public void renameSnapshot(final Path path, final
String snapshotOldName,
new SnapshotNameParam(snapshotNewName)).run();
}
- public SnapshotDiffReport getSnapshotDiffReport(final Path snapshotDir,
- final String fromSnapshot, final String toSnapshot) throws IOException {
- statistics.incrementReadOps(1);
- storageStatistics.incrementOpCounter(OpType.GET_SNAPSHOT_DIFF);
- final HttpOpParam.Op op = GetOpParam.Op.GETSNAPSHOTDIFF;
- return new FsPathResponseRunner<SnapshotDiffReport>(op, snapshotDir,
+ private boolean isValidSnapshotName(String snapshotName) {
Review comment:
I moved common logic to DFSUtilClient.
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java
##########
@@ -1460,6 +1472,64 @@ SnapshotDiffReport decodeResponse(Map<?, ?> json) {
}.run();
}
+ public SnapshotDiffReport getSnapshotDiffReport(final Path snapshotDir,
Review comment:
I moved common logic to DFSUtilClient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
