[
https://issues.apache.org/jira/browse/HADOOP-17559?focusedWorklogId=662240&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-662240
]
ASF GitHub Bot logged work on HADOOP-17559:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Oct/21 23:28
Start Date: 07/Oct/21 23:28
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #2734:
URL: https://github.com/apache/hadoop/pull/2734#issuecomment-937431834
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 662240)
Time Spent: 1h 20m (was: 1h 10m)
> S3Guard import can OOM on large imports
> ---------------------------------------
>
> Key: HADOOP-17559
> URL: https://issues.apache.org/jira/browse/HADOOP-17559
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.3.1
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> I know I'm closing ~all S3Guard issues as wontfix, but this is pressing so
> I'm going to do it anyway
> S3guard import of directory tree containing many, many files will OOM.
> Looking at the code this is going to be because
> * import tool builds a map of all dirs imported, which as the comments note
> "superfluous for DDB". - *cut*
> * DDB AncestorState tracks files as well as dirs, purely as a safety check to
> make sure current op doesn't somehow write a file entry above a dir entry in
> the same operation
> We've been running S3Guard for a long time, and condition #2 has never arisen.
> Propose: don't store filenames there, so memory consumption goes from O(files
> + dirs) to O(dirs)
> Code straightforward, can't think of any tests
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]