GauthamBanasandra opened a new pull request #3536:
URL: https://github.com/apache/hadoop/pull/3536
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g.,
'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
Currently, the test cases written in hdfs-tool-test.h isn't easy to reuse.
Primarily because the expectations are different for each HDFS tool. I realized
this while I was creating the PR for
[HDFS-16260](https://issues.apache.org/jira/browse/HDFS-16260). For instance,
passing more than one argument is erroneous to hdfs_allowSnapshot while it's
the only valid scenario for hdfs_deleteSnapshot.
Thus, it won't be possible to reuse the test cases without decoupling the
expectations from the test case definitions. The solution here is to move the
expectations to the corresponding mock classes and invoke the call to set them
up in the test cases after the creation of mock instances.
### How was this patch tested?
Unit tests ran successfully -
### For code changes:
- [x] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
