steveloughran commented on a change in pull request #3525:
URL: https://github.com/apache/hadoop/pull/3525#discussion_r729975058
##########
File path:
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/auth/delegation/ITestSessionDelegationInFileystem.java
##########
@@ -145,9 +145,13 @@ protected Configuration createConfiguration() {
// disable if assume role opts are off
assumeSessionTestsEnabled(conf);
disableFilesystemCaching(conf);
- String s3EncryptionMethod =
- conf.getTrimmed(Constants.S3_ENCRYPTION_ALGORITHM,
- S3AEncryptionMethods.SSE_KMS.getMethod());
+ String s3EncryptionMethod;
+ try {
+ s3EncryptionMethod =
+ getEncryptionAlgorithm(getTestBucketName(conf), conf).getMethod();
+ } catch (IOException e) {
+ throw new RuntimeException("Failed to lookup encryption algorithm.");
Review comment:
nit: should throw UncheckedIOException, as it's a good habit to get into
-certainly I'd expect in production code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
