[
https://issues.apache.org/jira/browse/HADOOP-17953?focusedWorklogId=665831&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-665831
]
ASF GitHub Bot logged work on HADOOP-17953:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/Oct/21 00:37
Start Date: 17/Oct/21 00:37
Worklog Time Spent: 10m
Work Description: steveloughran commented on a change in pull request
#3525:
URL: https://github.com/apache/hadoop/pull/3525#discussion_r729975058
##########
File path:
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/auth/delegation/ITestSessionDelegationInFileystem.java
##########
@@ -145,9 +145,13 @@ protected Configuration createConfiguration() {
// disable if assume role opts are off
assumeSessionTestsEnabled(conf);
disableFilesystemCaching(conf);
- String s3EncryptionMethod =
- conf.getTrimmed(Constants.S3_ENCRYPTION_ALGORITHM,
- S3AEncryptionMethods.SSE_KMS.getMethod());
+ String s3EncryptionMethod;
+ try {
+ s3EncryptionMethod =
+ getEncryptionAlgorithm(getTestBucketName(conf), conf).getMethod();
+ } catch (IOException e) {
+ throw new RuntimeException("Failed to lookup encryption algorithm.");
Review comment:
nit: should throw UncheckedIOException, as it's a good habit to get into
-certainly I'd expect in production code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 665831)
Time Spent: 40m (was: 0.5h)
> S3A: ITestS3AFileContextStatistics test to lookup global or per-bucket
> configuration for encryption algorithm
> -------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-17953
> URL: https://issues.apache.org/jira/browse/HADOOP-17953
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs/s3
> Affects Versions: 3.4.0
> Reporter: Mehakmeet Singh
> Assignee: Mehakmeet Singh
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> ITestS3AFileContextStatistics uses the conf.get() method to get the global
> configuration for encryption algorithm and keys, but the per-bucket
> configuration would be ignored in this case.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
