[ 
https://issues.apache.org/jira/browse/HADOOP-17880?focusedWorklogId=666425&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-666425
 ]

ASF GitHub Bot logged work on HADOOP-17880:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 18/Oct/21 17:17
            Start Date: 18/Oct/21 17:17
    Worklog Time Spent: 10m 
      Work Description: GauthamBanasandra commented on a change in pull request 
#3535:
URL: https://github.com/apache/hadoop/pull/3535#discussion_r731149203



##########
File path: dev-support/docker/pkg-resolver/resolve.py
##########
@@ -0,0 +1,62 @@
+#!/usr/bin/env python3
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+"""
+Platform package dependency resolver for building Apache Hadoop.
+"""
+
+from __future__ import print_function

Review comment:
       The cause for the pylint warning was that we use Python 3 in Hadoop 3.x 
and we're still using Python 2 in Hadoop 2.x. Instead of importing the 
`print_function`, could you please rewrite the print statement using Python 2 
syntax? I feel this is a better approach since all the Python scripts in Hadoop 
2.x is written in Python 2.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 666425)
    Time Spent: 10.5h  (was: 10h 20m)

> Build 2.10.x with docker
> ------------------------
>
>                 Key: HADOOP-17880
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17880
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.10.0
>         Environment: mac os x86_64
>            Reporter: baizhendong
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10.5h
>  Remaining Estimate: 0h
>
> 1. currently, we build the hadoop 2.10.0 with docker machine, and must 
> install Virtual Box, and for hadoop 3.x, just build with docker only.
> 2. besides this, the docker image dependency is out of date, and some of them 
> is unavaialble, for example – jdk7
> 3. but just building hadoop 2.10.0 with hadoop 3.x build script without 
> modification is not working, for the protocol buffer version is not 2.5.0, 
> and it's not work for native build.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to