virajjasani commented on a change in pull request #3555: URL: https://github.com/apache/hadoop/pull/3555#discussion_r731706600
########## File path: pom.xml ########## @@ -200,6 +200,14 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/x <bannedImport>com.google.common.collect.Lists</bannedImport> </bannedImports> </restrictImports> + <restrictImports implementation="de.skuzzle.enforcer.restrictimports.rule.RestrictImports"> + <includeTestCode>true</includeTestCode> + <reason>Use hadoop-common provided VisibleForTesting rather than the one provided by Guava</reason> + <bannedImports> + <bannedImport>org.apache.hadoop.thirdparty.com.google.common.annotations.VisibleForTesting</bannedImport> + <bannedImport>com.google.common.annotations.VisibleForTesting</bannedImport> Review comment: Oh yes, I am going to cover this as part of HADOOP-17968 just after this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
