amahussein opened a new pull request #3566:
URL: https://github.com/apache/hadoop/pull/3566


   
   
   ### Description of PR
   
   Replace `guava.Preconditions` in folder `hadoop-hdfs-project` with 
`hadoop.util.Preconditions`
   
   ### How was this patch tested?
   
   Ran the tests locally
   
   ### For code changes:
   
   - [X] Does the title or this PR starts with the corresponding JIRA issue id 
(e.g. 'HADOOP-17970. Your PR title ...')?
   - [X] There were 4 positions calling `checkPositionIndex`. Since there were 
only 4 occurrences I preferred to inline them in the code. The tradeoff is a 
slight change of behavior as guava.Preconditions.checkPositionIndex may throw 
`IllegalArgumentException`, while the inlined version only throws 
`IndexOutOfBoundsException`
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to