tomicooler commented on pull request #3460: URL: https://github.com/apache/hadoop/pull/3460#issuecomment-947455323
The CapacitySchedulerTestBase was killed in YARN-10692. The setUp and tearDown phases look similar but the TestCapacitySchedulerNodes doesn't rely on the mockContext for example. The only common member variable would be the resourceManager object. The helper functions could be in the base class, but then they would not be usable by other test classes unless they extend the base. I don't think we would benefit from the base class in this case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
