tomscut commented on pull request #3574: URL: https://github.com/apache/hadoop/pull/3574#issuecomment-950177682
> Thanx @tomscut, There is one test which still failed with timeout in one of the build. https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3574/2/testReport/org.apache.hadoop.hdfs/TestHDFSFileSystemContract/testAppend/ > > Apart, I don't think we should add timeout for the tests which doesn't have it now. I see you introduced timeouts for some. I don't want to risk seeing them fail in future with timeouts, the builds times are very unpredictable nowadays Thanks @ayushtkn for your review and comment. I fixed this failed unit test ```TestHDFSFileSystemContract#testAppend```, and it passed the latest round of tests. https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3574/3/testReport/org.apache.hadoop.hdfs/TestHDFSFileSystemContract/testAppend/ I added timeout on this ```TestViewFileSystemOverloadSchemeWithHdfsScheme#testAccessViewFsPathWithoutAuthority```, and I just rolled back. The other three places I added timeout because they all extend from ```FileSystemContractBaseTest``` and set the default timeout ```30 * 1000```. ``` @Rule public Timeout globalTimeout = new Timeout(getGlobalTimeout(), TimeUnit.MILLISECONDS); protected int getGlobalTimeout() { return 30 * 1000; } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
