jojochuang commented on pull request #3538:
URL: https://github.com/apache/hadoop/pull/3538#issuecomment-950643667
The API is declared Public, Evolving. If it stays in Hadoop 3.4.0 I am fine
with it.
We used to have an audit logger (Cloudera Navigator) that extends the
AuditLogger interface. But we've moved away from that.
Performance:
It would have a slight performance penalty because every audit log op will
always convert InetAddress to a string, regardless if audit logger is off
(audit log level = debug or dfs.namenode.audit.log.debug.cmdlist has the
excluded op)). It's probably acceptable since audit is logged outside of
namenode lock.
CallerContext:
the caller context is probably a better option when you want to do
fine-grained post-mortem anyway. Maybe we can modify the caller context to
attach remote port so that it doesn't break api compatibility. Just a thought.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
