amahussein commented on a change in pull request #3584: URL: https://github.com/apache/hadoop/pull/3584#discussion_r735640282
########## File path: pom.xml ########## @@ -208,6 +208,55 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/x <bannedImport>com.google.common.annotations.VisibleForTesting</bannedImport> </bannedImports> </restrictImports> + <restrictImports implementation="de.skuzzle.enforcer.restrictimports.rule.RestrictImports"> + <includeTestCode>true</includeTestCode> + <reason>com.google.common package usages are prohibited</reason> + <bannedImports> + <bannedImport>com.google.common.**</bannedImport> + </bannedImports> + </restrictImports> + <restrictImports implementation="de.skuzzle.enforcer.restrictimports.rule.RestrictImports"> + <includeTestCode>true</includeTestCode> + <reason>org.apache.hadoop.thirdparty.com.google.common.io.BaseEncoding package usages are prohibited</reason> + <bannedImports> + <bannedImport>org.apache.hadoop.thirdparty.com.google.common.io.BaseEncoding</bannedImport> + </bannedImports> + </restrictImports> + <restrictImports implementation="de.skuzzle.enforcer.restrictimports.rule.RestrictImports"> + <includeTestCode>true</includeTestCode> + <reason>org.apache.hadoop.thirdparty.com.google.common.base.Optional package usages are prohibited</reason> + <bannedImports> + <bannedImport>org.apache.hadoop.thirdparty.com.google.common.base.Optional</bannedImport> + </bannedImports> + </restrictImports> + <restrictImports implementation="de.skuzzle.enforcer.restrictimports.rule.RestrictImports"> + <includeTestCode>true</includeTestCode> + <reason>org.apache.hadoop.thirdparty.com.google.common.base.Function package usages are prohibited</reason> + <bannedImports> + <bannedImport>org.apache.hadoop.thirdparty.com.google.common.base.Function</bannedImport> + </bannedImports> + </restrictImports> + <restrictImports implementation="de.skuzzle.enforcer.restrictimports.rule.RestrictImports"> + <includeTestCode>true</includeTestCode> + <reason>org.apache.hadoop.thirdparty.com.google.common.base.Predicate package usages are prohibited</reason> + <bannedImports> + <bannedImport>org.apache.hadoop.thirdparty.com.google.common.base.Predicate</bannedImport> + </bannedImports> + </restrictImports> + <restrictImports implementation="de.skuzzle.enforcer.restrictimports.rule.RestrictImports"> + <includeTestCode>true</includeTestCode> + <reason>org.apache.hadoop.thirdparty.com.google.common.base.Supplier package usages are prohibited</reason> + <bannedImports> + <bannedImport>org.apache.hadoop.thirdparty.com.google.common.base.Supplier</bannedImport> + </bannedImports> + </restrictImports> + <restrictImports implementation="de.skuzzle.enforcer.restrictimports.rule.RestrictImports"> + <includeTestCode>true</includeTestCode> + <reason>org.apache.hadoop.thirdparty.com.google.common.collect.ImmutableListMultimap package usages are prohibited</reason> + <bannedImports> + <bannedImport>org.apache.hadoop.thirdparty.com.google.common.collect.ImmutableListMultimap</bannedImport> + </bannedImports> + </restrictImports> Review comment: Don't we need to keep "sun" packages? it is in the checkstyle illegal-imports -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
