[
https://issues.apache.org/jira/browse/HADOOP-17968?focusedWorklogId=669685&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-669685
]
ASF GitHub Bot logged work on HADOOP-17968:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/Oct/21 17:58
Start Date: 25/Oct/21 17:58
Worklog Time Spent: 10m
Work Description: virajjasani commented on a change in pull request #3584:
URL: https://github.com/apache/hadoop/pull/3584#discussion_r735836290
##########
File path: pom.xml
##########
@@ -208,6 +208,55 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
https://maven.apache.org/x
<bannedImport>com.google.common.annotations.VisibleForTesting</bannedImport>
</bannedImports>
</restrictImports>
+ <restrictImports
implementation="de.skuzzle.enforcer.restrictimports.rule.RestrictImports">
+ <includeTestCode>true</includeTestCode>
+ <reason>com.google.common package usages are
prohibited</reason>
+ <bannedImports>
+ <bannedImport>com.google.common.**</bannedImport>
+ </bannedImports>
+ </restrictImports>
+ <restrictImports
implementation="de.skuzzle.enforcer.restrictimports.rule.RestrictImports">
+ <includeTestCode>true</includeTestCode>
+
<reason>org.apache.hadoop.thirdparty.com.google.common.io.BaseEncoding package
usages are prohibited</reason>
+ <bannedImports>
+
<bannedImport>org.apache.hadoop.thirdparty.com.google.common.io.BaseEncoding</bannedImport>
+ </bannedImports>
+ </restrictImports>
+ <restrictImports
implementation="de.skuzzle.enforcer.restrictimports.rule.RestrictImports">
+ <includeTestCode>true</includeTestCode>
+
<reason>org.apache.hadoop.thirdparty.com.google.common.base.Optional package
usages are prohibited</reason>
+ <bannedImports>
+
<bannedImport>org.apache.hadoop.thirdparty.com.google.common.base.Optional</bannedImport>
+ </bannedImports>
+ </restrictImports>
+ <restrictImports
implementation="de.skuzzle.enforcer.restrictimports.rule.RestrictImports">
+ <includeTestCode>true</includeTestCode>
+
<reason>org.apache.hadoop.thirdparty.com.google.common.base.Function package
usages are prohibited</reason>
+ <bannedImports>
+
<bannedImport>org.apache.hadoop.thirdparty.com.google.common.base.Function</bannedImport>
+ </bannedImports>
+ </restrictImports>
+ <restrictImports
implementation="de.skuzzle.enforcer.restrictimports.rule.RestrictImports">
+ <includeTestCode>true</includeTestCode>
+
<reason>org.apache.hadoop.thirdparty.com.google.common.base.Predicate package
usages are prohibited</reason>
+ <bannedImports>
+
<bannedImport>org.apache.hadoop.thirdparty.com.google.common.base.Predicate</bannedImport>
+ </bannedImports>
+ </restrictImports>
+ <restrictImports
implementation="de.skuzzle.enforcer.restrictimports.rule.RestrictImports">
+ <includeTestCode>true</includeTestCode>
+
<reason>org.apache.hadoop.thirdparty.com.google.common.base.Supplier package
usages are prohibited</reason>
+ <bannedImports>
+
<bannedImport>org.apache.hadoop.thirdparty.com.google.common.base.Supplier</bannedImport>
+ </bannedImports>
+ </restrictImports>
+ <restrictImports
implementation="de.skuzzle.enforcer.restrictimports.rule.RestrictImports">
+ <includeTestCode>true</includeTestCode>
+
<reason>org.apache.hadoop.thirdparty.com.google.common.collect.ImmutableListMultimap
package usages are prohibited</reason>
+ <bannedImports>
+
<bannedImport>org.apache.hadoop.thirdparty.com.google.common.collect.ImmutableListMultimap</bannedImport>
+ </bannedImports>
+ </restrictImports>
Review comment:
> I see! I think that if the jira is to migrate "guava packages" then we
may keep `checkstyle.illegal-import` entry for `sun packages`?
Sounds good, let me put back sun packages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 669685)
Time Spent: 1h (was: 50m)
> Migrate checkstyle module illegalimport to maven enforcer
> banned-illegal-imports
> --------------------------------------------------------------------------------
>
> Key: HADOOP-17968
> URL: https://issues.apache.org/jira/browse/HADOOP-17968
> Project: Hadoop Common
> Issue Type: Task
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> As discussed on PR [3503|https://github.com/apache/hadoop/pull/3503], we
> should migrate existing imports provided in IllegalImport tag in
> checkstyle.xml to maven-enforcer-plugin's banned-illegal-imports enforcer
> rule so that build never succeeds in the presence of any of the illegal
> imports.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
