tasanuma commented on pull request #3564: URL: https://github.com/apache/hadoop/pull/3564#issuecomment-952599759
@tomscut Thanks for the explanation. When `nodeID` is DatanodeRegistration (I think it is most likely case), `DatanodeRegistration#toString()` is most informative. `nodeID.getDatanodeUuid()`: ``` BLOCK* processReport 0x51eb6427619ccf8f: Processing first storage report for DS-ced48a3c-7e37-4a94-9cf9-404e07e659a7 from datanode a7a8fd2f-e0cd-40a4-8fcd-65760b6bc6e6 ``` `nodeID.getXferAddrWithHostname()`: ``` BLOCK* processReport 0x5006fb6a4251db51: Processing first storage report for DS-ced48a3c-7e37-4a94-9cf9-404e07e659a7 from datanode hostname:11001 ``` `nodeID`: ``` BLOCK* processReport 0xe518c3bd634f15e6: Processing first storage report for DS-0048bf1d-84da-444c-8c3f-251dab39f1dc from datanode DatanodeRegistration(127.0.0.1:11000, datanodeUuid=64886279-5799-47a6-96ba-653e3675e816, infoPort=11020, infoSecurePort=0, ipcPort=11010, storageInfo=lv=-57;cid=CID-130467d5-c200-4869-9330-d9eedf4f3909;nsid=930729152;c=1635316881247) ``` So just using `nodeID` looks good to me. > because changing the toString() of the datanodeID or DatanodeRegistration might cause other compatibility issues. I agreed. Let's keep it as it was. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
