goiri commented on a change in pull request #3595:
URL: https://github.com/apache/hadoop/pull/3595#discussion_r742199623
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java
##########
@@ -765,6 +765,14 @@ BatchedDirectoryListing getBatchedListing(
@Idempotent
void renewLease(String clientName) throws IOException;
+ /**
+ * The functionality is the same as renewLease(clientName). This is to
support
+ * router based FileSystem to newLease against a specific target FileSystem
instead
+ * of all the target FileSystems in each call.
+ */
+ @Idempotent
+ void renewLease(String clientName, String nsId) throws IOException;
Review comment:
That's a good point.
ClientProtocol shouldn't care about subclusters.
The whole abstraction is based on paths and that would make more sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
