[
https://issues.apache.org/jira/browse/HADOOP-17997?focusedWorklogId=679201&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-679201
]
ASF GitHub Bot logged work on HADOOP-17997:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Nov/21 17:29
Start Date: 09/Nov/21 17:29
Worklog Time Spent: 10m
Work Description: goiri commented on a change in pull request #3634:
URL: https://github.com/apache/hadoop/pull/3634#discussion_r745849964
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Quota.java
##########
@@ -50,7 +50,7 @@ public static Counts newInstance() {
* The quota is violated if quota is set and usage > quota.
*/
public static boolean isViolated(final long quota, final long usage) {
- return quota >= 0 && usage > quota;
+ return quota >= 0 && usage >= quota;
Review comment:
The core of the change seems to be general HDFS not just RBF, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 679201)
Time Spent: 0.5h (was: 20m)
> RBF: Namespace usage of mount table with multi subclusters can exceed quota
> ---------------------------------------------------------------------------
>
> Key: HADOOP-17997
> URL: https://issues.apache.org/jira/browse/HADOOP-17997
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: xichaomin
> Priority: Major
> Labels: pull-request-available
> Attachments: 1636424307319.jpg
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> # mkdir on each subcluster /test10
> # mount table: hdfs dfsrouteradmin -add /test10 ns1,ns2 /test10
> # set quota: hdfs dfsrouteradmin -setQuota /test10 -nsQuota 4
> # touch two files under hdfs://\{fed}/test10, now the namespace usage is 4(2
> directories and 2 files).
> # refresh and put a new file, the put is successfull, and the namespace
> usage comes to 5.
> !1636424307319.jpg!
> The router checks quota without considering the increments, It is difficult
> to limit quota precisely without increments , but throw exception when usage
> >= quota will be better.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
