mariosmeim-db commented on a change in pull request #3440:
URL: https://github.com/apache/hadoop/pull/3440#discussion_r746436364
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java
##########
@@ -113,13 +119,14 @@ private AbfsClient(final URL baseUrl, final
SharedKeyCredentials sharedKeyCreden
this.retryPolicy = abfsClientContext.getExponentialRetryPolicy();
this.accountName = abfsConfiguration.getAccountName().substring(0,
abfsConfiguration.getAccountName().indexOf(AbfsHttpConstants.DOT));
this.authType = abfsConfiguration.getAuthType(accountName);
+ this.encryptionContextProvider = encryptionContextProvider;
String encryptionKey = this.abfsConfiguration
.getClientProvidedEncryptionKey();
if (encryptionKey != null) {
- this.clientProvidedEncryptionKey = getBase64EncodedString(encryptionKey);
- this.clientProvidedEncryptionKeySHA = getBase64EncodedString(
- getSHA256Hash(encryptionKey));
+ this.clientProvidedEncryptionKey =
EncryptionAdapter.getBase64EncodedString(encryptionKey);
Review comment:
Well, it can just accept the encoded key and decode it. I am not sure
which one is the best way, I was just pointing out that azCopy requires the
encoded key instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
