ayushtkn commented on a change in pull request #3469:
URL: https://github.com/apache/hadoop/pull/3469#discussion_r747693806
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/IncrementalBlockReportManager.java
##########
@@ -212,6 +212,8 @@ void sendIBRs(DatanodeProtocol namenode,
DatanodeRegistration registration,
namenode.blockReceivedAndDeleted(registration, bpid, reports);
success = true;
} finally {
+ /* set blocks to zero */
+ this.dnMetrics.resetBlocksInPendingIBR();
Review comment:
Couldn't check in detail but shouldn't this be in success block? In case
it isn't success, it puts the blocks back into the queue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
