GuoPhilipse commented on a change in pull request #3655:
URL: https://github.com/apache/hadoop/pull/3655#discussion_r748726616
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestAvailableSpaceRackFaultTolerantBPP.java
##########
@@ -189,6 +189,13 @@ public void testChooseDataNode() {
}
}
+ @Test
+ public void testDefaultConfigValue() {
+ Assert.assertEquals(
+
conf.get("DFS_NAMENODE_AVAILABLE_SPACE_RACK_FAULT_TOLERANT_BLOCK_PLACEMENT_POLICY_BALANCED_SPACE_PREFERENCE_FRACTION_KEY")
+ ,0.6f);
+ }
+
Review comment:
> This isn't required, this isn't checking the BPP, but how the conf
object works. you can remove this test.
Thanks @ayushtkn for your review. I have removed the test case, but not sure
if the CI will pass if no tests added. hope it works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
