[
https://issues.apache.org/jira/browse/HADOOP-18009?focusedWorklogId=681172&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-681172
]
ASF GitHub Bot logged work on HADOOP-18009:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Nov/21 22:53
Start Date: 13/Nov/21 22:53
Worklog Time Spent: 10m
Work Description: odrepa opened a new pull request #3656:
URL: https://github.com/apache/hadoop/pull/3656
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g.,
'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
This pull request aims to reset shared state between TestSecureRegistry and
TestRegistryOperationUtils, where TestRegistryOperationUtils (namely
testUsernameExtractionEnvVarOverrride) fails when run afterwards in the same
JVM. While currently test classes are run in separate JVMs, they can be run
faster when run in the same JVM, and the shared state can be reset with the
proposed patch in this pull request.
### How was this patch tested?
Before this patch, if the two test classes TestSecureRegistry and
TestRegistryOperationUtils are run in this order within the same JVM (Surefire
configuration reuseForks=true), TestRegistryOperationUtils fails. After the
patch, the test passes in the order.
### For code changes:
- [ ] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 681172)
Remaining Estimate: 0h
Time Spent: 10m
> Reset state after running TestSecureRegistry
> --------------------------------------------
>
> Key: HADOOP-18009
> URL: https://issues.apache.org/jira/browse/HADOOP-18009
> Project: Hadoop Common
> Issue Type: Test
> Components: registry
> Reporter: OD Repair
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> If test class TestRegistryOperationUtils runs after TestSecureRegistry in the
> same JVM, test
> TestRegistryOperationUtils#testUsernameExtractionEnvVarOverrride fails due to
> shared state between tests resulting in a wrong returned username. While
> currently the build process runs every test class in its own, separate JVM,
> tests could be sped up by running in the same JVM, and the state should be
> easy to reset.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
