[
https://issues.apache.org/jira/browse/HADOOP-17999?focusedWorklogId=681690&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-681690
]
ASF GitHub Bot logged work on HADOOP-17999:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Nov/21 20:29
Start Date: 15/Nov/21 20:29
Worklog Time Spent: 10m
Work Description: shvachko commented on a change in pull request #3639:
URL: https://github.com/apache/hadoop/pull/3639#discussion_r749658488
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
##########
@@ -917,13 +917,9 @@ public void removeXAttr(Path path, String name) throws
IOException {
}
@Override
- public void setVerifyChecksum(final boolean verifyChecksum) {
- List<InodeTree.MountPoint<FileSystem>> mountPoints =
- fsState.getMountPoints();
- Map<String, FileSystem> fsMap = initializeMountedFileSystems(mountPoints);
- for (InodeTree.MountPoint<FileSystem> mount : mountPoints) {
- fsMap.get(mount.src).setVerifyChecksum(verifyChecksum);
- }
+ public void setVerifyChecksum(final boolean verifyChecksum) {
Review comment:
Looks like the default impl. in FileSystem is already no-op. So the
value of overriding is only in the comment. May be we should just remove this
methods and add a comment to the jira explaining the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 681690)
Time Spent: 40m (was: 0.5h)
> ViewFileSystem.setVerifyChecksum should not initialize all target filesystems
> -----------------------------------------------------------------------------
>
> Key: HADOOP-17999
> URL: https://issues.apache.org/jira/browse/HADOOP-17999
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Abhishek Das
> Assignee: Abhishek Das
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently setVerifyChecksum and setWriteChecksum initializes all target file
> systems which causes delay in hadoop shell copy commands such as get, put,
> copyFromLocal etc.
> This also eventually causes OOM.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
