haiyang1987 commented on a change in pull request #3651:
URL: https://github.com/apache/hadoop/pull/3651#discussion_r749867573
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
##########
@@ -2390,15 +2394,24 @@ String reconfigureParallelLoad(String newVal) {
String reconfigureSlowNodesParameters(final DatanodeManager datanodeManager,
final String property, final String newVal) throws
ReconfigurationException {
+ BlockManager bm = namesystem.getBlockManager();
namesystem.writeLock();
boolean enable;
try {
- if (newVal == null) {
- enable = DFS_NAMENODE_AVOID_SLOW_DATANODE_FOR_READ_DEFAULT;
+ if (property.equals(DFS_NAMENODE_AVOID_SLOW_DATANODE_FOR_READ_KEY)) {
+ enable = (newVal == null ?
DFS_NAMENODE_AVOID_SLOW_DATANODE_FOR_READ_DEFAULT :
+ Boolean.parseBoolean(newVal));
+ datanodeManager.setAvoidSlowDataNodesForReadEnabled(enable);
+ } else if (property.equals(
+ DFS_NAMENODE_BLOCKPLACEMENTPOLICY_EXCLUDE_SLOW_NODES_ENABLED_KEY))
{
+ enable = (newVal == null ?
+
DFS_NAMENODE_BLOCKPLACEMENTPOLICY_EXCLUDE_SLOW_NODES_ENABLED_DEFAULT :
+ Boolean.parseBoolean(newVal));
+ bm.setExculeSlowDataNodesForWriteEnabled(enable);
} else {
- enable = Boolean.parseBoolean(newVal);
+ throw new IllegalArgumentException("Unexpected property " +
+ property + "in reconfReplicationParameters");
Review comment:
@tomscut Thank you for your reply.
Fixed and updated PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
