steveloughran commented on a change in pull request #3710:
URL: https://github.com/apache/hadoop/pull/3710#discussion_r755034309
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
##########
@@ -1099,6 +1099,20 @@ private synchronized void addResourceObject(Resource
resource) {
return result;
}
+ /**
+ * Provides a public wrapper over substituteVars in order to avoid
compatibility issues.
+ * See YARN-11013 for further details.
Review comment:
replace with HADOOP-18021
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
##########
@@ -1126,7 +1140,7 @@ private synchronized void addResourceObject(Resource
resource) {
* @throws IllegalArgumentException when more than
* {@link Configuration#MAX_SUBST} replacements are required
*/
- public String substituteVars(String expr) {
+ private String substituteVars(String expr) {
Review comment:
mention in the javadocs that oozie has a subclass with a method of this
name, so it must be kept private
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
