GuoPhilipse commented on pull request #3713: URL: https://github.com/apache/hadoop/pull/3713#issuecomment-978005246
> Thanks for writing the test @GuoPhilipse. Could you also add one additional test in `TestDFSPermission` because that way we can also test creating some file and then test `checkAccess()` through `FileSystem#access` with existing and non-existing files? This way we will have coverage for Mockito (as you did) as well as HDFS FS API. Thanks > Thanks for writing the test @GuoPhilipse. Could you also add one additional test in `TestDFSPermission` because that way we can also test creating some file and then test `checkAccess()` through `FileSystem#access` with existing and non-existing files? This way we will have coverage for Mockito (as you did) as well as HDFS FS API. Thanks Sure, have just updated. thanks for reminding me @virajjasani -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
