[
https://issues.apache.org/jira/browse/HADOOP-18022?focusedWorklogId=686844&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-686844
]
ASF GitHub Bot logged work on HADOOP-18022:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Nov/21 13:21
Start Date: 26/Nov/21 13:21
Worklog Time Spent: 10m
Work Description: virajjasani commented on pull request #3712:
URL: https://github.com/apache/hadoop/pull/3712#issuecomment-979974529
Thanks @tasanuma for the review.
> I'm not sure why banned-illegal-imports can't catch it.
Yeah indeed good question. Thanks to this incident that I realized that
static imports are not caught unless explicitly mentioned so I have fixed pom
for Preconditions static imports in the recent commit.
As part of separate Jira, we can add static import tag for all other such
banned imports. Sounds good?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 686844)
Time Spent: 3h (was: 2h 50m)
> Add restrict-imports-enforcer-rule for Guava Preconditions in hadoop-main pom
> -----------------------------------------------------------------------------
>
> Key: HADOOP-18022
> URL: https://issues.apache.org/jira/browse/HADOOP-18022
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Add restrict-imports-enforcer-rule for Guava Preconditions in hadoop-main pom
> to restrict any new import in future. Remove any remaining usages of Guava
> Preconditions from the codebase.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
