tomscut commented on a change in pull request #3731:
URL: https://github.com/apache/hadoop/pull/3731#discussion_r758865364
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcServer.java
##########
@@ -726,9 +727,10 @@ static String getMethodName() {
* @return List of name spaces in the federation on
* removing the already invoked namespaceinfo.
*/
- private Set<FederationNamespaceInfo> getNameSpaceInfo(String nsId) {
+ private Set<FederationNamespaceInfo> getNameSpaceInfo(
+ Set<FederationNamespaceInfo> nss, String nsId) {
Set<FederationNamespaceInfo> namespaceInfos = new HashSet<>();
- for (FederationNamespaceInfo ns : namespaceInfos) {
+ for (FederationNamespaceInfo ns : nss) {
Review comment:
Thanks @goiri for your comments and suggestion. I rolled back the way
catching with log and replaced with calling #getServerDefaults (create a
separate unit test #testInvokeAtAvailableNs). PTAL. Thanks a lot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
