Desmeister commented on a change in pull request #3739:
URL: https://github.com/apache/hadoop/pull/3739#discussion_r759873860
##########
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodecFactory.java
##########
@@ -137,9 +138,15 @@ private static CompressionCodecFactory setClasses(Class[]
classes) {
private static void checkCodec(String msg,
Class expected, CompressionCodec actual) {
- assertEquals(msg + " unexpected codec found",
- expected.getName(),
- actual.getClass().getName());
+ if (expected == null) {
+ assertNull(msg, actual);
+ } else if (actual == null) {
Review comment:
Yes; assertNull has a detailed builtin message. Here's an example of the
new messages:
When a result was expected:
`java.lang.AssertionError: default factory for .gz result was null`
When null was expected:
`java.lang.AssertionError: default factory for .gz expected null, but
was:<org.apache.hadoop.io.compress.GzipCodec@3108bc>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
