ashutoshcipher commented on a change in pull request #3728:
URL: https://github.com/apache/hadoop/pull/3728#discussion_r761654212
##########
File path:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/LeveldbTimelineStore.java
##########
@@ -242,19 +240,7 @@ protected void serviceInit(Configuration conf) throws
Exception {
IOUtils.cleanupWithLogger(LOG, localFS);
}
LOG.info("Using leveldb path " + dbPath);
- try {
- db = factory.open(new File(dbPath.toString()), options);
- } catch (IOException ioe) {
- File dbFile = new File(dbPath.toString());
- File backupPath = new File(
- dbPath.toString() + BACKUP_EXT + Time.monotonicNow());
- LOG.warn("Incurred exception while loading LevelDb database. Backing " +
- "up at "+ backupPath, ioe);
- FileUtils.copyDirectory(dbFile, backupPath);
- LOG.warn("Going to try repair");
Review comment:
I think we can remove that. Thanks for the suggestion.
##########
File path:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/RollingLevelDBTimelineStore.java
##########
@@ -18,10 +18,10 @@
package org.apache.hadoop.yarn.server.timeline;
+
Review comment:
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
