[
https://issues.apache.org/jira/browse/HADOOP-18028?focusedWorklogId=690391&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-690391
]
ASF GitHub Bot logged work on HADOOP-18028:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Dec/21 00:00
Start Date: 04/Dec/21 00:00
Worklog Time Spent: 10m
Work Description: bhalchandrap commented on a change in pull request
#3736:
URL: https://github.com/apache/hadoop/pull/3736#discussion_r762350797
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/common/BlockData.java
##########
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hadoop.fs.common;
+
+/**
+ * Holds information about blocks of data in an S3 file.
+ */
+public class BlockData {
+ // State of each block of data.
+ enum State {
+ // Data is not yet ready to be read.
+ NOT_READY,
+
+ // A read of this block has been queued.
+ QUEUED,
+
+ // This block is ready to be read.
+ READY,
+
+ // This block has been cached.
+ CACHED
+ }
+
+ // State of all blocks in an S3 file.
+ private State[] state;
+
+ // The size of an S3 file.
+ private final long fileSize;
+
+ // The S3 file is divided into blocks of this size.
+ private final int blockSize;
+
+ // The S3 file has these many blocks.
+ private final int numBlocks;
+
+ /**
+ * Constructs an instance of {@link BlockData}.
+ *
+ * @param fileSize the size of an S3 file.
+ * @param blockSize the S3 file is divided into blocks of this size.
+ */
+ public BlockData(long fileSize, int blockSize) {
+ Validate.checkNotNegative(fileSize, "fileSize");
+ if (fileSize == 0) {
+ Validate.checkNotNegative(blockSize, "blockSize");
+ } else {
+ Validate.checkPositiveInteger(blockSize, "blockSize");
+ }
+
+ this.fileSize = fileSize;
+ this.blockSize = blockSize;
+ this.numBlocks =
+ (fileSize == 0) ? 0 : ((int) (fileSize / blockSize)) + (fileSize %
blockSize > 0 ? 1 : 0);
+ this.state = new State[this.numBlocks];
+ for (int b = 0; b < this.numBlocks; b++) {
+ this.setState(b, State.NOT_READY);
+ }
+ }
+
+ public int getBlockSize() {
+ return this.blockSize;
+ }
+
+ public long getFileSize() {
+ return this.fileSize;
+ }
+
+ public int getNumBlocks() {
+ return this.numBlocks;
+ }
+
+ public boolean isLastBlock(int blockNumber) {
+ if (this.fileSize == 0) {
+ return false;
+ }
+
+ throwIfInvalidBlockNumber(blockNumber);
+
+ return blockNumber == (this.numBlocks - 1);
+ }
+
+ public int getBlockNumber(long offset) {
+ throwIfInvalidOffset(offset);
+
+ return (int) (offset / this.blockSize);
+ }
+
+ public int getSize(int blockNumber) {
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 690391)
Time Spent: 4h 20m (was: 4h 10m)
> improve S3 read speed using prefetching & caching
> -------------------------------------------------
>
> Key: HADOOP-18028
> URL: https://issues.apache.org/jira/browse/HADOOP-18028
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs/s3
> Reporter: Bhalchandra Pandit
> Priority: Major
> Labels: pull-request-available
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> I work for Pinterest. I developed a technique for vastly improving read
> throughput when reading from the S3 file system. It not only helps the
> sequential read case (like reading a SequenceFile) but also significantly
> improves read throughput of a random access case (like reading Parquet). This
> technique has been very useful in significantly improving efficiency of the
> data processing jobs at Pinterest.
>
> I would like to contribute that feature to Apache Hadoop. More details on
> this technique are available in this blog I wrote recently:
> [https://medium.com/pinterest-engineering/improving-efficiency-and-reducing-runtime-using-s3-read-optimization-b31da4b60fa0]
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
