ayushtkn commented on a change in pull request #3671:
URL: https://github.com/apache/hadoop/pull/3671#discussion_r762400115
##########
File path:
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/db/DBOutputFormat.java
##########
@@ -122,7 +122,7 @@ public void write(K key, V value) throws IOException {
key.write(statement);
statement.addBatch();
} catch (SQLException e) {
- e.printStackTrace();
+ throw new RuntimeException("Failed to execute SQL statement for key "
+ key, e);
Review comment:
In other places. It is converting the SQLException to IOE.
``
catch (SQLException ex) {
throw new IOException(ex.getMessage());
``
Can we keep the same behaviour, will that also solve the problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
