GuoPhilipse commented on a change in pull request #3729:
URL: https://github.com/apache/hadoop/pull/3729#discussion_r762411958
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSUtilClient.java
##########
@@ -733,13 +733,13 @@ public static boolean isLocalAddress(InetSocketAddress
targetAddr)
InetAddress addr = targetAddr.getAddress();
Boolean cached = localAddrMap.get(addr.getHostAddress());
if (cached != null) {
- LOG.trace("Address {} is {} local", targetAddr, (cached ? "" : "not"));
+ LOG.trace("Address " + targetAddr + (cached ? " is local" : " is not
local"));
Review comment:
>
just a feeling ,not that perfect ,but current change is a relative simple
fix way. btw, we don't need to add the test case for this kind of log info fix
,right ? @ayushtkn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
