virajjasani commented on a change in pull request #3684:
URL: https://github.com/apache/hadoop/pull/3684#discussion_r762810004
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java
##########
@@ -582,12 +582,12 @@ void doImportCheckpoint(FSNamesystem target) throws
IOException {
if (checkpointDirs == null || checkpointDirs.isEmpty()) {
throw new IOException("Cannot import image from a checkpoint. "
- + "\"dfs.namenode.checkpoint.dir\" is not set." );
+ + "\"dfs.namenode.checkpoint.dir\" is not set.");
}
if (checkpointEditsDirs == null || checkpointEditsDirs.isEmpty()) {
Review comment:
Yeah it seems fine, just an additional null check, not a big deal. Also
good to keep it for future safety as you predicted correctly, just in case if
the methods themselves start returning null (less likely but still doable).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
