aajisaka commented on pull request #3765: URL: https://github.com/apache/hadoop/pull/3765#issuecomment-988780046
Thank you @virajjasani and @iwasakims for your comments. > Does this fix means -DignoreTestFailure overrides -Dmaven.test.failure.ignore? Yes. Now `ignoreTestFailure` is set in pom.xml, therefore setting `maven.test.failure.ignore` from command line has no effect. I'm +1 to use `maven.test.failure.ignore` rather than `ignoreTestFailure` because it is more simple. However, given this change is already committed in trunk and branch-3.3, let's use `maven.test.failure.ignore` and drop `ignoreTestFailure` in a separate issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
