brumi1024 commented on a change in pull request #3660:
URL: https://github.com/apache/hadoop/pull/3660#discussion_r765126207
##########
File path:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacitySchedulerConfiguration.java
##########
@@ -2189,6 +2189,11 @@ public String
getAutoCreatedQueueTemplateConfPrefix(String queuePath) {
return queuePath + DOT + AUTO_CREATED_LEAF_QUEUE_TEMPLATE_PREFIX;
}
+ @Private
+ public QueuePath getAutoCreatedQueueObjectTemplateConfPrefix(String
queuePath) {
+ return new QueuePath(queuePath, AUTO_CREATED_LEAF_QUEUE_TEMPLATE_PREFIX);
Review comment:
Maybe a factory method could be created, which returns a new QueuePath
with the parent set as the original queuePath. I.e
rootQueuePath.createChild(String childName) -> this could return a new
QueuePath object with root.childName path, and rootQueuePath as parent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
