tomscut commented on pull request #3786:
URL: https://github.com/apache/hadoop/pull/3786#issuecomment-991477452
> Thanks @tomscut for your report. It is almost LGTM. Some nits, a. There
are also some other logs which only leaves DataNodeUUID, do you mind to
complete them with address together? b. Just suggest to invoke
`dn.getXferAddr()` to keep the log style same. e.g. `200 LOG.info("Registered
DN {} ({}).", dn.getDatanodeUuid(), dn.getXferAddr());`
Thank you very much for your review and suggestion. Can we change
`getXferAddr` to `getXferAddrWithHostname`, because `hostname` may be more
intuitive than `IP`. What do you think? I will correct the omissions together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
