tasanuma commented on a change in pull request #3784:
URL: https://github.com/apache/hadoop/pull/3784#discussion_r769497669
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
##########
@@ -967,6 +968,7 @@ private synchronized void removeVolumes(
// Remove volumes and block infos from FsDataset.
data.removeVolumes(storageLocations, clearFailure);
+ Preconditions.checkNotNull(data, "Storage not yet initialized");
Review comment:
Maybe this check should be before `data.removeVolumes(storageLocations,
clearFailure); `?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
