minni31 commented on a change in pull request #3766:
URL: https://github.com/apache/hadoop/pull/3766#discussion_r769830187
##########
File path:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/policies/amrmproxy/LocalityMulticastAMRMProxyPolicy.java
##########
@@ -195,9 +198,14 @@ public void notifyOfResponse(SubClusterId subClusterId,
AllocateResponse response) throws YarnException {
if (response.getAvailableResources() != null) {
headroom.put(subClusterId, response.getAvailableResources());
- LOG.info("Subcluster {} updated with {} memory headroom", subClusterId,
- response.getAvailableResources().getMemorySize());
}
+ if (response.getEnhancedHeadroom() != null) {
+ this.enhancedHeadroom.put(subClusterId, response.getEnhancedHeadroom());
Review comment:
I think it should be fine to break changes into two JIRAs for ease of
validations. What are your thoughts ? Should I merge them into one PR only ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
