balvisio commented on a change in pull request #3292:
URL: https://github.com/apache/hadoop/pull/3292#discussion_r770357840
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
##########
@@ -415,12 +422,16 @@ public void initialize(URI name, Configuration
originalConf)
// DT Bindings may override this
setEncryptionSecrets(new EncryptionSecrets(
getEncryptionAlgorithm(bucket, conf),
- getServerSideEncryptionKey(bucket, getConf())));
+ getS3EncryptionKey(bucket, getConf())));
invoker = new Invoker(new S3ARetryPolicy(getConf()), onRetry);
instrumentation = new S3AInstrumentation(uri);
initializeStatisticsBinding();
-
+ // If CSE-KMS method is set then CSE is enabled.
+ isCSEEnabled = S3AUtils.lookupPassword(conf,
Review comment:
@mehakmeet : I was just reviewing this PR to get some understanding.
Wondering why the `isCSEEnabled` check only compares if the
`SERVER_SIDE_ENCRYPTION_ALGORITHM` param is not equal to null. Shouldn't it be:
(identical to the one in `DefaultS3ClientFactory.java`)
```
if (S3AEncryptionMethods.getMethod(S3AUtils.
lookupPassword(conf, SERVER_SIDE_ENCRYPTION_ALGORITHM, null))
.equals(S3AEncryptionMethods.CSE_KMS)) {
```
I see that this check is changed in `trunk`(to compare equal to `CSE-KMS`
but making sure I am not missing something here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
