virajjasani commented on pull request #3802: URL: https://github.com/apache/hadoop/pull/3802#issuecomment-996678300
> LGTM I believe it was broken by [HADOOP-17452](https://issues.apache.org/jira/browse/HADOOP-17452) and so my only question is why didn't our UT catch the issue and if we need extra tests. I agree, we need more tests in yarn-nodemanager and yarn-resourcemanager modules. For ATSv2, timelineservice-tests module has some tests but the above two modules should also have some tests. On the other hand, hbase 1 profile will most likely not require any more version upgrade and when hbase 3 is rolled out, we can focus on providing better compatibilities and good no of tests to cover new profile (perhaps make it default profile). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
