taiyang-li commented on a change in pull request #3797:
URL: https://github.com/apache/hadoop/pull/3797#discussion_r771820322
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java
##########
@@ -1204,16 +1207,38 @@ public void setBalancerBandwidth(long bandwidth) throws
IOException {
@Override
public ContentSummary getContentSummary(String path) throws IOException {
+ return getContentSummary(path, new HashMap<String, Set<String>>());
+ }
+
+ public ContentSummary getContentSummary(String path, Map<String,
Set<String>> excludeNamespace) throws IOException {
rpcServer.checkOperation(NameNode.OperationCategory.READ);
// Get the summaries from regular files
final Collection<ContentSummary> summaries = new ArrayList<>();
final List<RemoteLocation> locations =
rpcServer.getLocationsForPath(path, false, false);
+ Map<String, Set<String>> currentExcludePathNsMap = new HashMap<>();
+ Set<String> curExcludeNamespace = new HashSet<>();
+ String destPath =
subclusterResolver.getDestinationForPath(path).getDefaultLocation().getDest();
+ List<String> parentExistLocations =
excludeNamespace.keySet().stream().filter(s -> destPath.startsWith(s))
+ .collect(Collectors.toList());
+ boolean parentAlreadyComputed = parentExistLocations.size() > 0;
+ List<RemoteLocation> filterLoctions =
+ locations.stream().filter(remoteLocation -> excludeNamespace.isEmpty()
|| !parentAlreadyComputed ||
+ !isParentPathNamespaceComputed(remoteLocation, excludeNamespace,
parentExistLocations))
+ .collect(Collectors.toList());
+ filterLoctions.forEach(remoteLocation -> {
+ curExcludeNamespace.add(remoteLocation.getNameserviceId());
+ });
+ if (excludeNamespace.get(destPath) != null) {
+ excludeNamespace.get(destPath).addAll(curExcludeNamespace);
+ } else {
+ excludeNamespace.put(destPath, curExcludeNamespace);
+ }
final RemoteMethod method = new RemoteMethod("getContentSummary",
new Class<?>[] {String.class}, new RemoteParam());
final List<RemoteResult<RemoteLocation, ContentSummary>> results =
- rpcClient.invokeConcurrent(locations, method,
+ rpcClient.invokeConcurrent(filterLoctions, method,
Review comment:
Find wrong spelling of `filterLocations`..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
