tomscut commented on a change in pull request #3753:
URL: https://github.com/apache/hadoop/pull/3753#discussion_r773573177
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/metrics/DataNodeDiskMetrics.java
##########
@@ -127,6 +143,16 @@ public void run() {
detectAndUpdateDiskOutliers(metadataOpStats, readIoStats,
writeIoStats);
+
+ // Sort the slow disks by latency.
+ if (maxSlowDisksToBeExcluded > 0) {
+ ArrayList<DiskLatency> diskLatencies = new ArrayList<>();
+ for (Map.Entry<String, Map<DiskOp, Double>> diskStats :
+ diskOutliersStats.entrySet()) {
+ diskLatencies.add(new DiskLatency(diskStats.getKey(),
diskStats.getValue()));
+ }
+ sortSlowDisks(diskLatencies);
Review comment:
Thank you @tasanuma very much for your review and comments. I think your
suggestions are very good. I will revise ASAP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
