[
https://issues.apache.org/jira/browse/HADOOP-17609?focusedWorklogId=699857&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-699857
]
ASF GitHub Bot logged work on HADOOP-17609:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Dec/21 09:09
Start Date: 22/Dec/21 09:09
Worklog Time Spent: 10m
Work Description: jojochuang commented on a change in pull request #3019:
URL: https://github.com/apache/hadoop/pull/3019#discussion_r773721930
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/OpensslSm4CtrCryptoCodec.java
##########
@@ -41,6 +41,10 @@ public OpensslSm4CtrCryptoCodec() {
if (loadingFailureReason != null) {
throw new RuntimeException(loadingFailureReason);
}
+
+ if (!OpensslCipher.isSupported(CipherSuite.SM4_CTR_NOPADDING)) {
+ throw new RuntimeException("Doesn't support SM4 CTR.");
Review comment:
How about making the message "the openssl native library is built
without SM4 CTR support"?
the rest looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 699857)
Time Spent: 4h 20m (was: 4h 10m)
> Make SM4 support optional for OpenSSL native code
> -------------------------------------------------
>
> Key: HADOOP-17609
> URL: https://issues.apache.org/jira/browse/HADOOP-17609
> Project: Hadoop Common
> Issue Type: Improvement
> Components: native
> Affects Versions: 3.4.0
> Reporter: Masatake Iwasaki
> Assignee: Masatake Iwasaki
> Priority: Major
> Labels: pull-request-available
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> openssl-devel-1.1.1g provided by CentOS 8 does not work after HDFS-15098
> because the SM4 is not enabled on the openssl package. We should not force
> users to install OpenSSL from source code even if they do not use SM4 feature.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
