KevinWikant commented on a change in pull request #3675: URL: https://github.com/apache/hadoop/pull/3675#discussion_r774293566
########## File path: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestDatanodeAdminMonitorBase.java ########## @@ -0,0 +1,95 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hdfs.server.blockmanagement; + +import org.junit.Assert; +import org.junit.Test; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.Arrays; +import java.util.List; +import java.util.PriorityQueue; +import java.util.stream.Collectors; + +import org.apache.hadoop.hdfs.protocol.DatanodeID; + +public class TestDatanodeAdminMonitorBase { + public static final Logger LOG = LoggerFactory.getLogger(TestDatanodeAdminMonitorBase.class); + + // Sort by lastUpdate time descending order, such that unhealthy + // nodes are de-prioritized given they cannot be decommissioned. + private static final int NUM_DATANODE = 10; + private static final int[] UNORDERED_LAST_UPDATE_TIMES = + new int[] {0, 5, 2, 11, 0, 3, 1001, 5, 1, 103}; + private static final int[] ORDERED_LAST_UPDATE_TIMES = + new int[] {1001, 103, 11, 5, 5, 3, 2, 1, 0, 0}; + private static final int[] REVERSE_ORDER_LAST_UPDATE_TIMES = + new int[] {0, 0, 1, 2, 3, 5, 5, 11, 103, 1001}; + + private static final DatanodeDescriptor[] NODES; + + static { + NODES = new DatanodeDescriptor[NUM_DATANODE]; + for (int i = 0; i < NUM_DATANODE; i++) { + NODES[i] = new DatanodeDescriptor(DatanodeID.EMPTY_DATANODE_ID); + NODES[i].setLastUpdate(UNORDERED_LAST_UPDATE_TIMES[i]); + NODES[i].setLastUpdateMonotonic(UNORDERED_LAST_UPDATE_TIMES[i]); + } + } + + /** + * Verify that DatanodeAdminManager pendingNodes priority queue + * correctly orders the nodes by lastUpdate time descending. + */ + @Test + public void testPendingNodesQueueOrdering() { + final PriorityQueue<DatanodeDescriptor> pendingNodes = + new PriorityQueue<>(10, + DatanodeAdminMonitorBase.PENDING_NODES_QUEUE_COMPARATOR); + + for (int i = 0; i < NUM_DATANODE; i++) { + pendingNodes.add(NODES[i]); + } Review comment: updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
