aajisaka commented on pull request #3824: URL: https://github.com/apache/hadoop/pull/3824#issuecomment-1000741700
Thank you @virajjasani for your patch. This feature looks very helpful for us to investigate the root cause of some performance issues. I'll build and deploy Hadoop cluster and test this feature. Now I have one comment: We need to add an additional access control for this servlet like [ConfServlet](https://github.com/apache/hadoop/blob/e103c83765898f756f88c27b2243c8dd3098a989/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ConfServlet.java#L61-L64). In addition, we need to update the document of `hadoop.security.instrumentation.requires.admin`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
