ashutoshcipher commented on a change in pull request #3836:
URL: https://github.com/apache/hadoop/pull/3836#discussion_r775884338
##########
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/zstd/TestZStandardCompressorDecompressor.java
##########
@@ -231,6 +231,65 @@ public void
testCompressorDecompressorLogicWithCompressionStreams()
}
}
+ /**
+ * Verify decompressor logic with some finish operation in compress.
+ */
+ @Test
+ public void testCompressorDecompressorWithFinish() throws Exception {
+ DataOutputStream deflateOut = null;
+ DataInputStream inflateIn = null;
+ int byteSize = 1024 * 100;
+ byte[] bytes = generate(byteSize);
+ int firstLength = 1024 * 30;
+
+ int bufferSize = IO_FILE_BUFFER_SIZE_DEFAULT;
+ try {
+ DataOutputBuffer compressedDataBuffer = new DataOutputBuffer();
+ CompressionOutputStream deflateFilter =
+ new CompressorStream(compressedDataBuffer, new
ZStandardCompressor(),
+ bufferSize);
+
+ deflateOut =
+ new DataOutputStream(new BufferedOutputStream(deflateFilter));
+
+ // Write some data and finish.
+ deflateOut.write(bytes, 0, firstLength);
+ deflateFilter.finish();
+ deflateOut.flush();
+
+ // ResetState then write some data and finish.
+ deflateFilter.resetState();
+ deflateOut.write(bytes, firstLength, firstLength);
+ deflateFilter.finish();
+ deflateOut.flush();
+
+ // ResetState then write some data and finish.
+ deflateFilter.resetState();
+ deflateOut.write(bytes, firstLength * 2, byteSize - firstLength * 2);
+ deflateFilter.finish();
+ deflateOut.flush();
+
+ DataInputBuffer deCompressedDataBuffer = new DataInputBuffer();
+ deCompressedDataBuffer.reset(compressedDataBuffer.getData(), 0,
+ compressedDataBuffer.getLength());
+
+ CompressionInputStream inflateFilter =
+ new DecompressorStream(deCompressedDataBuffer,
+ new ZStandardDecompressor(bufferSize), bufferSize);
+
+ inflateIn = new DataInputStream(new BufferedInputStream(inflateFilter));
+
+ byte[] result = new byte[byteSize];
+ inflateIn.read(result);
+ assertArrayEquals(
+ "original array not equals compress/decompressed array", result,
+ bytes);
Review comment:
I will do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]