secfree commented on pull request #3837: URL: https://github.com/apache/hadoop/pull/3837#issuecomment-1002546807
@ferhui yes, you are right. Now only `DatanodeManager#registerDatanode` calls `reloadCachedMappings` and it handles the parameters well. So it is ok to keep the current version. But for CachedDNSToSwitchMapping itself, `resolve` and `reloadCachedMappings` are not consistent, as the UT shows. I meet a related issue when implementing the topology refreshing feature. If others need to implement other features, they may also encounter similar issues. It is ok for me to leave this patch un-merged. It is up to you, master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
